-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mix format #478
mix format #478
Conversation
I see value in this, especially for collaboration, but I'd prefer to wait for a new maintainer to make these decisions |
yeah i just submitted it as a placeholder. |
The number of files affected is big. Let me revisit this after getting a bit more comfortable with the code. I intend to merge this. |
yes it saw that. I wasn't sure if it was bc formatting styles had really changed, or existing suntax was unconventional or what |
as I was working alone for quite a period of time, I did only apply my own style which is quite unconventional, too bad one is so egostic, sorry I left a little technical debt here |
A little whitespace never hurt anyone. It's a pretty adjustment when we feel good about it :) |
I don't know what this says about me but I do have the time and ambition enough to go through and verify that all that is changing in whitespace if you want to plug me in. :) |
I don't want to subject you to that, I do have this on my mind. I was looking around to see if there was a more definite widespread style guide we could adopt. regardless, I appreciate it. |
I removed everything except the one format file |
@amit-chaudhari1 courageous move 👏 will help a lot for collaboration |
I ran "mix format" and it changes the formatting of 109 files. so maybe better to start that change from the source :)